Wire IBIT zscore exit runtime settings#119
Conversation
362e0d2 to
ed08611
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 362e0d22c1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| firstrade==0.0.39 | ||
| quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@46ca4ea3de8f98a58e2dd86158e7f2070d085cd1 | ||
| us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@173b8abbabc6a281b4707e100d248eae99e1f9d5 | ||
| us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@ced1f78827e6112292af24d32dfe0e0f009e2833 |
There was a problem hiding this comment.
Avoid pulling in the global ETF snapshot migration
This pin advances through the upstream commit that changes global_etf_rotation from direct market_history/portfolio_snapshot inputs to snapshot-backed feature_snapshot artifacts. In this repo, tests/test_strategy_registry.py still asserts the Firstrade adapter for global_etf_rotation uses broker runtime inputs, and the env-sync workflow will now require FIRSTRADE_FEATURE_SNAPSHOT_PATH for that profile; existing global ETF deployments without snapshot artifacts will start failing env sync instead of running from broker market data. Please either pin to a strategy commit that contains only the IBIT changes or update the platform/test/configuration for the new snapshot-backed contract.
Useful? React with 👍 / 👎.
Summary
IBIT_ZSCORE_EXIT_*runtime env settings and pass them only toibit_smart_dca.us-equity-strategiesto the commit that contains IBIT z-score exit and BOXX-funded DCA support.Test Plan